Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull/fetch/push: add stats #3735

Merged
merged 5 commits into from
May 5, 2020
Merged

pull/fetch/push: add stats #3735

merged 5 commits into from
May 5, 2020

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented May 4, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Closes #3485

$ dvc pull
M	bar
A	foo
1 file added, 1 file modified and 2 files fetched
$ dvc push
2 files pushed
$ dvc fetch
1 file fetched

@skshetry skshetry added the ui user interface / interaction label May 4, 2020
@skshetry skshetry requested a review from efiop May 4, 2020 12:14
@skshetry skshetry self-assigned this May 4, 2020
@skshetry skshetry requested review from pared and pmrowla May 4, 2020 12:14
@skshetry skshetry marked this pull request as draft May 4, 2020 12:27
@skshetry

This comment has been minimized.

@skshetry skshetry marked this pull request as ready for review May 4, 2020 13:02
@pared
Copy link
Contributor

pared commented May 4, 2020

@skshetry seems like you need to modify test_data_sync unit command tests. Now we are mocking fetch and push return value, and logger is unable to parse it.

@skshetry
Copy link
Member Author

skshetry commented May 4, 2020

Thanks @pared, I have adjusted the tests. I have set return_value, now the mock should be properly set.

@efiop efiop merged commit d00bd4d into iterative:master May 5, 2020
@efiop
Copy link
Contributor

efiop commented May 5, 2020

@skshetry Are you sure we don't need docs for this PR ?

@skshetry skshetry deleted the pull-stats branch May 26, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull/fetch: show how many files were downloaded
4 participants