-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
params: show only params files that are actually used #5541
Conversation
33d61f7
to
fc8ae6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intended originally, but now it is a mixup. Need to take a closer look and also look at the docs, as those might be affected. IIRC the logic was that people might use it without our pipelines (similar to same assumptions/discussions around metrics/plots). I don't feel comfortable just disabling this behavior, because it might turn out that it is needed in some scenario. We might need to double check params workflow first. |
@efiop, isn't expecting a There's |
@skshetry Hard to tell. Params/metrics and plots are all filled with assumptions that were provided by users while developing it, and I also get constantly confused by it. The change seems logical, but we just need to make sure it fits into the workflow and we def need to check the docs. |
So the whole issue started in #5451, where user has quite extensive pipeline, and running
I guess we all are. |
Closing, we do not intend to change default behaviour for now. |
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
Closes #5539