Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test_show_experiments_sort_by #6798

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Added test_show_experiments_sort_by #6798

merged 4 commits into from
Oct 14, 2021

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Oct 13, 2021

Behaviour was not really tested apart from return code (https://github.com/iterative/dvc/blob/master/tests/func/experiments/test_show.py#L366). Serves as regression for #6764

Generation of example data for testing experiment_table/ exp show stuff should probably be revisited.

@daavoo daavoo requested a review from a team as a code owner October 13, 2021 10:29
@daavoo daavoo requested a review from isidentical October 13, 2021 10:29
@daavoo daavoo self-assigned this Oct 13, 2021
@daavoo daavoo added testing Related to the tests and the testing infrastructure and removed testing Related to the tests and the testing infrastructure labels Oct 13, 2021
@pmrowla pmrowla self-requested a review October 14, 2021 03:41
@efiop efiop merged commit 7e4f443 into master Oct 14, 2021
@efiop efiop deleted the test-exp-show-sort-by branch October 14, 2021 11:49
@efiop efiop added testing Related to the tests and the testing infrastructure skip-changelog Skips changelog labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants