Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: repo: raise proper FileNotFoundError in metadata #7156

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

pared
Copy link
Contributor

@pared pared commented Dec 15, 2021

Related: #7120 #7157

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@pared pared requested a review from a team as a code owner December 15, 2021 10:29
@pared pared requested a review from karajan1001 December 15, 2021 10:29
@pared
Copy link
Contributor Author

pared commented Dec 15, 2021

Example and reproduction steps are described in #7120

In the example provided by me in #7120 (comment):

was:

$ dvc list .                                                                                   2.000s 
ERROR: unexpected error

after this change:

$ dvc list .                                                                                   0.000s 
ERROR: unexpected error - [Errno 2] No such file or directory: '/private/var/folders/f2/zs40fvgd4kd3z8jtzd9k0dxw0000gn/T/test_wspace/test_repo/link'

@pared
Copy link
Contributor Author

pared commented Dec 15, 2021

It seems to me that there are few places where we are raising empty generic exceptions. We should probably go over those and add some context.

@efiop efiop merged commit 8ca3a7b into iterative:main Dec 17, 2021
@efiop efiop added the enhancement Enhances DVC label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants