objects.db: get rid of callbacks from internal _list_paths API #7486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
refactoring
skshetry
force-pushed
the
get-rid-of-callbacks
branch
from
23da155
to
85771f3
Compare
This removes callback from internal APIs: `_list_paths`, `list_hashes`, and `_hashes_with_limit`. These are all iterators and hence can just be replaced by wrapping a progressbar over those iterators in the caller side. We still have progressbars in `hashes_exist`, `_estimate_remote_size`, `_list_hashes_traverse` and `list_hashes_exists`, which should gradually lifted up and replaced.
skshetry
force-pushed
the
get-rid-of-callbacks
branch
from
85771f3
to
2a3607c
Compare
skshetry
requested review from
dtrifiro and
pmrowla
and removed request for
pared
efiop
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes callback from internal APIs:
_list_paths,list_hashes,and
_hashes_with_limit. These are all iterators and hence can just bereplaced by wrapping a progress bar over those iterators on the caller
side.
We still have progress bars in
hashes_exist,_estimate_remote_size,_list_hashes_traverseandlist_hashes_exists, which should graduallybe lifted up and replaced.
I came over to this refactoring when investigating
webdavissue in #7288, and noticed that_list_pathscould be simpler.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏