-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] gs: fix import-url for directories #7655
Conversation
cd24f77
to
ff22c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be catching this external data stuff in the cloud tests (https://github.com/iterative/dvc-gs).
Seems that we are not really testing external data at all?
Similar thing happened in #7563
@daavoo Indeed, we specifically skip import_dir test in https://github.com/iterative/dvc-gs/blob/564592e28be38c8d45f7c04f0b07d0065a65f1b2/dvc_gs/tests/test_dvc.py#L39 I think this is for legacy reasons from way back when we used etags for dir hashes. We now use regular md5s, so might be able to make it work for gs. |
@dtrifiro The testing for gs is a bit complicated, because we are in the middle of creating plugins, so the tests run in https://github.com/iterative/dvc-gs (they have the creds and stuff there). If you don't happen to have set it up before, you could create a test PR in dvc-gs and make it install dvc from your fork and run the tests there, just to confirm that it works before merging this. |
Seems there are some failures. Will mark this PR as draft and investigate later |
Should we create a separate issue for this? |
This needs to be moved to https://github.com/iterative/dvc-objects |
ff22c3a
to
b2b3e30
Compare
bba3694
to
82629ce
Compare
82629ce
to
85882be
Compare
Closing this as this was merged in iterative/dvc-objects#41. Just need to wait for |
fixes #7638