-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp queue: Add two command queue remove
and queue kill
#7721
Conversation
Current UI $ dvc queue --help
usage: dvc queue [-h] [-q | -v] {remove,kill} ...
Commands to manage dvc task queue.
Documentation: <https://man.dvc.org/queue>
positional arguments:
{remove,kill} Use `dvc queue CMD --help` to display command-specific help.
remove Remove experiments in queue
kill Kill experiments in queue
optional arguments:
-h, --help show this help message and exit
-q, --quiet Be quiet.
-v, --verbose Be verbose.
$ dvc queue remove --help
usage: dvc queue remove [-h] [-q | -v] [--all] [<experiment> [<experiment> ...]]
Remove experiments in queue
Documentation: <https://man.dvc.org/queue/remove>
positional arguments:
<experiment> Experiments in queue to remove.
optional arguments:
-h, --help show this help message and exit
-q, --quiet Be quiet.
-v, --verbose Be verbose.
--all Remove all experiments in queue.
$ dvc queue kill --help
usage: dvc queue kill [-h] [-q | -v] [<experiment> [<experiment> ...]]
Kill experiments in queue
Documentation: <https://man.dvc.org/queue/kill>
positional arguments:
<experiment> Experiments in queue to kill.
optional arguments:
-h, --help show this help message and exit
-q, --quiet Be quiet.
-v, --verbose Be verbose. |
Should I wait for #7714 before testing this? |
023001f
to
5f77797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things, LGTM otherwise
@karajan1001 there's a linting error now (unused import), just fix that and then squash your commits and this can be merged |
Because it relates CLI, I'd prefer to wait for Dave's suggestion. |
fix: iterative#7591 1. Add a new command `dvc queue` 2. Add two sub-command `dvc queue remove` and `dvc queue kill` 3. Add a unit test to test them Co-authored-by: Peter Rowlands (λ³κΈ°νΈ) <peter@pmrowla.com>
The |
@dberenbaum Could you please give help on the product side? |
I think it may be easier for us to just merge these PRs into the dev branch so that testing can be done w/all of the commands available, and then iterate/fix bugs from there |
How soon do you expect to merge? If it's in the next couple days, I will wait. Otherwise, I'll try to look at what I can now. |
I think we can wait until the next couple of days. |
fix: #7591
dvc queue
dvc queue remove
anddvc queue kill
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
wait for #7714