Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queue remove: add remove support for short revs(#7840) #7841

Conversation

karajan1001
Copy link
Contributor

fix: #7840

Now queue remove can not accept short rev as name.

  1. We add support for short rev as name in queue remove.
  2. Better output if no queue task found for name.
  3. short rev on kill can only be work for rev with lens longer than 4

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@karajan1001 karajan1001 requested a review from pmrowla June 3, 2022 03:39
@karajan1001 karajan1001 requested a review from a team as a code owner June 3, 2022 03:39
@karajan1001 karajan1001 self-assigned this Jun 3, 2022
@karajan1001 karajan1001 linked an issue Jun 3, 2022 that may be closed by this pull request
@karajan1001 karajan1001 force-pushed the queue_remove_support_short_rev branch from 9bf6c07 to 653d2f8 Compare June 9, 2022 11:19
@pmrowla
Copy link
Contributor

pmrowla commented Jun 10, 2022

@karajan1001 latest changes look good, I'd still like to get rid of the string length check though (see latest review comments)

@karajan1001 karajan1001 force-pushed the queue_remove_support_short_rev branch from 7f2760c to 73c6916 Compare June 13, 2022 09:00
@karajan1001 karajan1001 force-pushed the queue_remove_support_short_rev branch from 73c6916 to 0fbeb4f Compare June 13, 2022 09:01
@karajan1001 karajan1001 deleted the queue_remove_support_short_rev branch June 13, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queue remove: add remove support for short revs
2 participants