Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: allow top-level strings #8482

Merged
merged 3 commits into from
Nov 4, 2022
Merged

plots: allow top-level strings #8482

merged 3 commits into from
Nov 4, 2022

Conversation

dberenbaum
Copy link
Collaborator

Follow up to #8412 to allow for entering file paths as strings instead of dict keys:

plots:
+  - path/to/file
-  - path/to/file:

Some of the JSON output tests are failing in tests/integration/plots/test_plots.py. @pared When you have a chance, could you take a look and see if you have any idea why?

@dberenbaum dberenbaum requested a review from pared October 27, 2022 17:19
@dberenbaum
Copy link
Collaborator Author

@dberenbaum
Copy link
Collaborator Author

Docs PR: iterative/dvc.org#4081

dvc/repo/plots/__init__.py Outdated Show resolved Hide resolved
dvc/repo/plots/__init__.py Outdated Show resolved Hide resolved
@dberenbaum
Copy link
Collaborator Author

@pared Could you merge when you have a chance? I don't have permission.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 94.26% // Head: 94.27% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9bcb65f) compared to base (15f35e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8482      +/-   ##
==========================================
+ Coverage   94.26%   94.27%   +0.01%     
==========================================
  Files         431      431              
  Lines       32812    32812              
  Branches     4576     4576              
==========================================
+ Hits        30929    30933       +4     
+ Misses       1464     1463       -1     
+ Partials      419      416       -3     
Impacted Files Coverage Δ
dvc/schema.py 100.00% <ø> (ø)
tests/func/test_dvcfile.py 100.00% <ø> (ø)
dvc/repo/experiments/queue/celery.py 84.68% <0.00%> (+1.43%) ⬆️
dvc/repo/experiments/queue/utils.py 80.00% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit d7152e3 into main Nov 4, 2022
@skshetry skshetry deleted the plots-allow-str branch November 4, 2022 04:09
@skshetry
Copy link
Member

skshetry commented Nov 4, 2022

@pared Could you merge when you have a chance? I don't have permission.

@dberenbaum, please check. I have fixed it (all had write permissions but somehow dvc-all had lesser permissions which I have switched).

@dberenbaum
Copy link
Collaborator Author

Thanks @skshetry. TBH I don't mind not having merge permissions (it might be a good separation of duties) but I think dvc-all would need maintain privileges to merge to main. Looks like I'm still blocked right now from merging.

@skshetry
Copy link
Member

skshetry commented Nov 4, 2022

@dberenbaum, Write does have merge permissions. See https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role.

What you may not have is

Merge pull requests on protected branches, even if there are no approving reviews

which requires Admin permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants