-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plots: allow top-level strings #8482
Conversation
Schema changes are in https://github.com/iterative/dvcyaml-schema/tree/top-level-plot-str |
Docs PR: iterative/dvc.org#4081 |
dde78a4
to
b86c235
Compare
@pared Could you merge when you have a chance? I don't have permission. |
Codecov ReportBase: 94.26% // Head: 94.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8482 +/- ##
==========================================
+ Coverage 94.26% 94.27% +0.01%
==========================================
Files 431 431
Lines 32812 32812
Branches 4576 4576
==========================================
+ Hits 30929 30933 +4
+ Misses 1464 1463 -1
+ Partials 419 416 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@dberenbaum, please check. I have fixed it ( |
Thanks @skshetry. TBH I don't mind not having merge permissions (it might be a good separation of duties) but I think |
@dberenbaum, What you may not have is
which requires Admin permissions. |
Follow up to #8412 to allow for entering file paths as strings instead of dict keys:
Some of the JSON output tests are failing in
tests/integration/plots/test_plots.py
. @pared When you have a chance, could you take a look and see if you have any idea why?