-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump dvc-data to 0.26.0 #8566
Conversation
Codecov ReportBase: 94.32% // Head: 94.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8566 +/- ##
==========================================
+ Coverage 94.32% 94.34% +0.02%
==========================================
Files 430 430
Lines 32835 32847 +12
Branches 4583 4584 +1
==========================================
+ Hits 30970 30989 +19
+ Misses 1447 1440 -7
Partials 418 418
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@efiop test failures aren't a sync issue. The problem is that in a lot of tests we do This only shows up in the import tests because in the import tests we immediately try to re-import files and eventually call Most of the other tests where we clear the cache we are checking for |
I'm not sure a user would ever hit this problem, so we could just add a test helper method that does something like clean_odb(odb):
remove(odb.path)
odb._dirs.clear() and use |
@pmrowla Great points! We also have |
Co-authored-by: Peter Rowlands <peter@iterative.ai>
Co-authored-by: Peter Rowlands peter@iterative.ai