hydra: Use OmegaConf.to_yaml for dumping .yaml output.
#8587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.28% // Head: 94.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8587 +/- ##
==========================================
- Coverage 94.28% 94.28% -0.01%
==========================================
Files 431 431
Lines 32919 32931 +12
Branches 4605 4607 +2
==========================================
+ Hits 31039 31048 +9
- Misses 1458 1461 +3
Partials 422 422
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dberenbaum
reviewed
Nov 18, 2022
dberenbaum
approved these changes
Nov 18, 2022
Combining `OmegaConf.to_object` with our yaml DUMPER (ruaml.yaml) was not correctly handling strings like 'no'. `OmegaConf.to_yaml` uses a custom string representer that correctly handles those cases. Fixes #8583 Co-authored-by: Dave Berenbaum <dave@iterative.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining
OmegaConf.to_objectwith our yaml DUMPER (ruaml.yaml) was not correctly handling strings like 'no'.OmegaConf.to_yamluses a custom string representer that correctly handles those cases.Fixes #8583