-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp save: simplify implementation #8690
Conversation
Gonna add a few more tests |
Codecov ReportBase: 93.52% // Head: 93.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8690 +/- ##
==========================================
- Coverage 93.52% 93.51% -0.02%
==========================================
Files 457 457
Lines 36128 36121 -7
Branches 5224 5229 +5
==========================================
- Hits 33790 33779 -11
- Misses 1837 1839 +2
- Partials 501 503 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fb31e6a
to
ce5668f
Compare
c0364ea
to
f07741f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably would be good to update the force
description in the cmd (
dvc/dvc/commands/experiments/save.py
Line 52 in 23e4d37
help="Save even if hash value for dependencies/outputs changed.", |
Hi. Are you planning to update docs after this? Not sure if actual behavior will be affected but if so, feel free to take over iterative/dvc.org#4200 to include them there. |
Hey @jorgeorpinel, behaviour should be identical to the current implementation, so there's no need to update the docs. |
f07741f
to
8fd6ffb
Compare
Gets rid of the queue/executor mechanism to save experiments.
fixes #8680