exp apply can accept exp names and failed exps as target
#8708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karajan1001
added
A: experiments
Codecov ReportBase: 93.50% // Head: 93.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8708 +/- ##
==========================================
+ Coverage 93.50% 93.51% +0.01%
==========================================
Files 457 457
Lines 36207 36229 +22
Branches 5246 5252 +6
==========================================
+ Hits 33854 33879 +25
+ Misses 1845 1843 -2
+ Partials 508 507 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pmrowla
reviewed
Dec 26, 2022
pmrowla
reviewed
Dec 26, 2022
1. Move get_ref_and_entry_by_names from `exp remove` to `celery` for other commands usage.
fix: iterative#8182 1. `exp apply` can apply to failed experiments. 2. `exp apply` can accept exp names as target. 3. Add a new functional test for it.
pmrowla
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8182
exp applycan apply to failed experiments.exp applycan accept exp names as targets.get_ref_and_entry_by_namesfromexp removetoutilsfor other commands' usage.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏