-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: expose http timeout in config schema #8722
Conversation
Codecov ReportBase: 93.52% // Head: 93.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8722 +/- ##
==========================================
- Coverage 93.52% 93.51% -0.01%
==========================================
Files 457 457
Lines 36229 36195 -34
Branches 5252 5242 -10
==========================================
- Hits 33882 33848 -34
+ Misses 1840 1839 -1
- Partials 507 508 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Related: iterative/dvc-http#25 |
fdafc9d
to
b123bea
Compare
b123bea
to
71534ff
Compare
071108a
to
df2b698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (the test that is failing also should not be here).
- `read_timeout` timeout for reading new data portions from the peer - `connect_timeout` timeout for establishing new connections For more information about individual timeouts meanings: - `read_timeout` maps to `aiohttp`'s `sock_read` timeout - `connect_timeout` applies to `aiohttp`'s `connect`, `sock_connect` timeouts https://docs.aiohttp.org/en/stable/client_reference.html?highlight=clienttimeout#clienttimeout
df2b698
to
5ac476f
Compare
… add`) (#4223) * remote modify: remove duplicate config options for s3 * remote modify: add timeout config options for http remote Related: iterative/dvc#8722 * Update content/docs/command-reference/remote/modify.md * Update content/docs/command-reference/remote/modify.md * Revert "Update content/docs/command-reference/remote/modify.md" This reverts commit 5cd4c2b. Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
read_timeout
maps toaiohttp
'ssock_read
timeout (read timeout while waiting for a new portion of data from the peer)connect_timeout
applies toaiohttp
'sconnect
,sock_connect
timeoutsFor more information:
https://docs.aiohttp.org/en/stable/client_reference.html?highlight=clienttimeout#clienttimeout