Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post_live_metrics: Pass params on start event. #8741

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Dec 27, 2022

No description provided.

@daavoo daavoo requested a review from nimdraugsael December 27, 2022 18:05
@daavoo daavoo added product: VSCode Integration with VSCode extension feature is a feature labels Dec 27, 2022
@daavoo daavoo self-assigned this Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 93.50% // Head: 93.51% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bf9c227) compared to base (ea8a4a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8741   +/-   ##
=======================================
  Coverage   93.50%   93.51%           
=======================================
  Files         457      457           
  Lines       36189    36195    +6     
  Branches     5240     5242    +2     
=======================================
+ Hits        33840    33848    +8     
+ Misses       1841     1839    -2     
  Partials      508      508           
Impacted Files Coverage Δ
tests/func/experiments/test_utils.py 100.00% <ø> (ø)
dvc/repo/experiments/queue/workspace.py 82.17% <100.00%> (ø)
dvc/repo/experiments/utils.py 81.76% <100.00%> (+0.66%) ⬆️
dvc/repo/params/show.py 93.93% <0.00%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit 68b2430 into main Dec 28, 2022
@daavoo daavoo deleted the live-metrics-params branch December 28, 2022 10:43
@daavoo daavoo added product: Studio Integration with Studio and removed product: VSCode Integration with VSCode extension labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature product: Studio Integration with Studio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants