Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: prevent re-download on every update #8752

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jan 2, 2023

fixes #8751

@dtrifiro dtrifiro requested a review from dberenbaum January 2, 2023 18:18
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 93.51% // Head: 93.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c07050) compared to base (a24c389).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8752   +/-   ##
=======================================
  Coverage   93.51%   93.52%           
=======================================
  Files         457      457           
  Lines       36249    36282   +33     
  Branches     5257     5262    +5     
=======================================
+ Hits        33899    33933   +34     
  Misses       1843     1843           
+ Partials      507      506    -1     
Impacted Files Coverage Δ
dvc/stage/imports.py 87.50% <100.00%> (+1.78%) ⬆️
tests/func/test_update.py 100.00% <100.00%> (ø)
tests/unit/stage/test_stage.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum
Copy link
Collaborator

Seems like the behavior between --no-download and --to-remote is inconsistent. We can fix in this PR or follow up with another one. For --to-remote, the outs metadata is updated with the new info but the workspace remains untouched, while --no-download drop the outs metadata and deletes anything in the workspace.

@dtrifiro dtrifiro marked this pull request as draft January 2, 2023 21:13
@dtrifiro dtrifiro marked this pull request as ready for review January 2, 2023 21:42
@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jan 2, 2023

Regarding --to-remote and --no-download, I think we can follow up later.

@dtrifiro dtrifiro enabled auto-merge (rebase) January 3, 2023 17:03
@dtrifiro dtrifiro merged commit 4b0fa4d into iterative:main Jan 3, 2023
@dtrifiro dtrifiro deleted the 8751-fix-update branch January 4, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

update: import-url updates will get re-downloaded even if nothing changes
2 participants