Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: hoist resolver/top-level metrics/plots/params data to file level #8754

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jan 3, 2023

where it makes sense, since it is a part of file rather than "StageLoader".

@skshetry skshetry self-assigned this Jan 3, 2023
@skshetry skshetry added the refactoring Factoring and re-factoring label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 93.52% // Head: 93.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e1ffaaa) compared to base (f386f7c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8754   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         457      457           
  Lines       36229    36249   +20     
  Branches     5252     5257    +5     
=======================================
+ Hits        33882    33902   +20     
  Misses       1840     1840           
  Partials      507      507           
Impacted Files Coverage Δ
dvc/dvcfile.py 96.78% <100.00%> (+0.32%) ⬆️
dvc/repo/stage.py 90.84% <100.00%> (ø)
dvc/stage/__init__.py 93.97% <100.00%> (+0.01%) ⬆️
dvc/stage/loader.py 99.18% <100.00%> (-0.06%) ⬇️
tests/func/test_stage.py 100.00% <100.00%> (ø)
tests/unit/stage/test_loader_pipeline_file.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit a24c389 into iterative:main Jan 3, 2023
@skshetry skshetry deleted the hoist-resolver-top-level-to-file branch January 3, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant