-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pathspec to 0.10.3 #8767
Bump pathspec to 0.10.3 #8767
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,7 @@ def mock_dvcignore(dvcignore_path, patterns): | |
("to_ignore.txt", ["/*.txt"], True), | ||
(os.path.join("path", "to_ignore.txt"), ["/*.txt"], False), | ||
(os.path.join("data", "file.txt"), ["data/*"], True), | ||
(os.path.join("data", "subdir", "file.txt"), ["data/*"], False), | ||
# (os.path.join("data", "subdir", "file.txt"), ["data/*"], False), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. commented-out test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a newly introduced bug by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a core use case? Do we need to maybe stick with an older version and report/fix this bug in pathspec? Is there a pathspec issue for it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we need to report to them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @karajan1001, can we workaround this? I don't think we should merge this with this bug otherwise. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @karajan1001 accidental merge or do you plan on fixing it in a followup? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current behavior is the same as
We should change it to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So this is a bugfix then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. |
||
(os.path.join("data", "file.txt"), ["data/"], True), | ||
(os.path.join("data", "subdir", "file.txt"), ["data/"], True), | ||
(os.path.join("data", "subdir", "file.txt"), ["subdir/"], True), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you have benchmarks for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I hadn't, The PR only did some name field jobs and didn't touch the matching logic.