Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output.remove: Pass explicit recursive flag #8825

Merged
merged 2 commits into from
Jan 18, 2023
Merged

output.remove: Pass explicit recursive flag #8825

merged 2 commits into from
Jan 18, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jan 16, 2023

Per changes in iterative/dvc-objects#176

@daavoo daavoo changed the title output: Explicit recursive flag. output.remove: Pass explicit recursive flag Jan 16, 2023
Copy link
Contributor Author

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires to release a new dvc-data version

@daavoo daavoo marked this pull request as ready for review January 18, 2023 09:11
- Update `test_gc`
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 93.59% // Head: 93.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8d4aa89) compared to base (9af6fca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8825   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files         453      453           
  Lines       36133    36139    +6     
  Branches     5248     5250    +2     
=======================================
+ Hits        33819    33825    +6     
  Misses       1811     1811           
  Partials      503      503           
Impacted Files Coverage Δ
dvc/output.py 87.42% <100.00%> (ø)
tests/func/test_gc.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants