-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: use index #8930
diff: use index #8930
Conversation
7e9f879
to
5bd8667
Compare
Codecov ReportBase: 93.34% // Head: 93.34% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8930 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 453 453
Lines 36510 36510
Branches 5278 5278
=======================================
Hits 34082 34082
Misses 1914 1914
Partials 514 514 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mnist bench results without any perf analysis: Most likely view is slowing us down, will double-check iterative/dvc-data#278 EDIT: nope, there is more to it |
`data_keys` are similar to `outs`, but they provide more granularity, so we can use them in `build_data_index` to rebuild index views with filtered outputs. E.g. when running `dvc diff dir/file`, workspace index should only have `dir/file` in it. This also could be used for standalone (non-output) data in the future. Pre-requisite for iterative#8930
`data_keys` are similar to `outs`, but they provide more granularity, so we can use them in `build_data_index` to rebuild index views with filtered outputs. E.g. when running `dvc diff dir/file`, workspace index should only have `dir/file` in it. This also could be used for standalone (non-output) data in the future. Pre-requisite for iterative#8930
`data_keys` are similar to `outs`, but they provide more granularity, so we can use them in `build_data_index` to rebuild index views with filtered outputs. E.g. when running `dvc diff dir/file`, workspace index should only have `dir/file` in it. This also could be used for standalone (non-output) data in the future. Pre-requisite for #8930
58a2af8
to
9cb65fe
Compare
861abf2
to
91970d7
Compare
Ok. let's run with this. A persistent index will cut it down further and there are additional changes to improve index restoration coming soon for all affected commands. |
No description provided.