Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp save: Use pathspec to handle include_untracked. #9064

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Feb 20, 2023

Closes #9061

@daavoo daavoo linked an issue Feb 20, 2023 that may be closed by this pull request
@daavoo daavoo requested review from a team and dtrifiro and removed request for a team and dtrifiro February 20, 2023 20:10
@daavoo daavoo added A: experiments Related to dvc exp bugfix fixes bug labels Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 93.02% // Head: 93.01% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (df6b485) compared to base (4720853).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9064      +/-   ##
==========================================
- Coverage   93.02%   93.01%   -0.02%     
==========================================
  Files         457      457              
  Lines       36901    36912      +11     
  Branches     5338     5339       +1     
==========================================
+ Hits        34328    34334       +6     
- Misses       2054     2057       +3     
- Partials      519      521       +2     
Impacted Files Coverage Δ
dvc/repo/experiments/save.py 95.23% <100.00%> (+0.23%) ⬆️
tests/func/experiments/test_save.py 100.00% <100.00%> (ø)
dvc/repo/experiments/queue/celery.py 85.92% <0.00%> (-1.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo enabled auto-merge (rebase) February 21, 2023 08:10
@daavoo daavoo force-pushed the 9061-exp-save-incorrect-warnings-about-untracked-files branch from 4f32689 to df6b485 Compare February 21, 2023 08:10
@daavoo daavoo merged commit 3043b65 into main Feb 21, 2023
@daavoo daavoo deleted the 9061-exp-save-incorrect-warnings-about-untracked-files branch February 21, 2023 08:43
daavoo added a commit to iterative/dvclive that referenced this pull request Mar 7, 2023
daavoo added a commit to iterative/dvclive that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp bugfix fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp save: Incorrect warnings about untracked files
2 participants