-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: fixtures: fix docker regression #9083
Conversation
Codecov ReportBase: 92.97% // Head: 92.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9083 +/- ##
==========================================
- Coverage 92.97% 92.66% -0.31%
==========================================
Files 459 459
Lines 37112 37115 +3
Branches 5365 5365
==========================================
- Hits 34505 34393 -112
- Misses 2080 2170 +90
- Partials 527 552 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I don't think this PR does anything. The fixture is return via |
# pylint: disable-next=import-error | ||
from pytest_docker.plugin import DockerComposeExecutor, Services | ||
|
||
executor = DockerComposeExecutor(docker_compose_file, docker_compose_project_name) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also incompatible with pytest_docker>=1
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a closer look at it...
I tested dvc-ssh without this PR on both |
@skshetry Hm, looks like I'm wrong here. Created a revert PR. dvc-ssh needs some investigation. |
Regression from #9054