Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: fixtures: fix docker regression #9083

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Feb 27, 2023

Regression from #9054

@efiop efiop added p0-critical testing Related to the tests and the testing infrastructure labels Feb 27, 2023
@efiop efiop self-assigned this Feb 27, 2023
@efiop efiop requested a review from skshetry February 27, 2023 12:02
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 92.97% // Head: 92.66% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (f8beeff) compared to base (2a2c02c).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9083      +/-   ##
==========================================
- Coverage   92.97%   92.66%   -0.31%     
==========================================
  Files         459      459              
  Lines       37112    37115       +3     
  Branches     5365     5365              
==========================================
- Hits        34505    34393     -112     
- Misses       2080     2170      +90     
- Partials      527      552      +25     
Impacted Files Coverage Δ
dvc/testing/fixtures.py 71.52% <25.00%> (-1.45%) ⬇️
tests/func/test_unprotect.py 78.57% <0.00%> (-21.43%) ⬇️
tests/unit/utils/test_utils.py 83.33% <0.00%> (-16.67%) ⬇️
tests/unit/test_daemon.py 85.18% <0.00%> (-14.82%) ⬇️
dvc/utils/fs.py 83.63% <0.00%> (-10.91%) ⬇️
tests/unit/proc/test_manager.py 89.28% <0.00%> (-10.72%) ⬇️
dvc/proc/manager.py 66.66% <0.00%> (-9.68%) ⬇️
tests/unit/utils/test_fs.py 88.42% <0.00%> (-9.48%) ⬇️
dvc/proc/exceptions.py 86.66% <0.00%> (-6.67%) ⬇️
dvc/config_schema.py 89.18% <0.00%> (-5.41%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop merged commit b80d84e into iterative:main Feb 27, 2023
@skshetry
Copy link
Member

I don't think this PR does anything. The fixture is return via yield.

Comment on lines +246 to +250
# pylint: disable-next=import-error
from pytest_docker.plugin import DockerComposeExecutor, Services

executor = DockerComposeExecutor(docker_compose_file, docker_compose_project_name)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also incompatible with pytest_docker>=1 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a closer look at it...

@skshetry
Copy link
Member

I tested dvc-ssh without this PR on both pytest_docker>=1 and pytest_docker<1, and it works. I think dvc_compose was the only thing that was making it fail.

@efiop
Copy link
Contributor Author

efiop commented Feb 27, 2023

@skshetry Hm, looks like I'm wrong here. Created a revert PR. dvc-ssh needs some investigation.

@efiop efiop removed the p0-critical label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to the tests and the testing infrastructure
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants