Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc.testing: fix lockfile in docker_services fixture #9088

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

skshetry
Copy link
Member

I wanted to depend on internals of pytest_docker as much as possible, but the lifecycle of it makes it very difficult to do so. (and considering we use pytest-xdist this makes it much harder).

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 5.88% and project coverage change: -0.04 ⚠️

Comparison is base (a91528c) 92.97% compared to head (f066180) 92.94%.

❗ Current head f066180 differs from pull request most recent head a36cdcd. Consider uploading reports for the commit a36cdcd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9088      +/-   ##
==========================================
- Coverage   92.97%   92.94%   -0.04%     
==========================================
  Files         459      459              
  Lines       37112    37125      +13     
  Branches     5365     5369       +4     
==========================================
  Hits        34506    34506              
- Misses       2079     2092      +13     
  Partials      527      527              
Impacted Files Coverage Δ
dvc/testing/fixtures.py 67.08% <5.88%> (-5.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

where we were not tearing down the containers
@skshetry skshetry force-pushed the fix-docker-lockfile branch from f066180 to a36cdcd Compare February 28, 2023 11:07
@skshetry skshetry merged commit 4a6f3ed into main Feb 28, 2023
@skshetry skshetry deleted the fix-docker-lockfile branch February 28, 2023 11:09
@efiop efiop added p0-critical testing Related to the tests and the testing infrastructure labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to the tests and the testing infrastructure
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants