Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: set hash_name as md5 #9097

Merged
merged 1 commit into from
Mar 1, 2023
Merged

remote: set hash_name as md5 #9097

merged 1 commit into from
Mar 1, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Mar 1, 2023

Fixes #7977

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.43 ⚠️

Comparison is base (1a7ae16) 92.97% compared to head (a13ccc6) 92.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9097      +/-   ##
==========================================
- Coverage   92.97%   92.55%   -0.43%     
==========================================
  Files         459      459              
  Lines       37106    37110       +4     
  Branches     5369     5365       -4     
==========================================
- Hits        34500    34347     -153     
- Misses       2079     2211     +132     
- Partials      527      552      +25     
Impacted Files Coverage Δ
tests/func/test_add.py 95.18% <ø> (-3.56%) ⬇️
tests/func/test_import_url.py 100.00% <ø> (ø)
dvc/testing/workspace_tests.py 51.98% <8.16%> (-12.07%) ⬇️
dvc/data_cloud.py 82.19% <100.00%> (ø)
tests/func/test_unprotect.py 78.57% <0.00%> (-21.43%) ⬇️
tests/unit/utils/test_utils.py 83.33% <0.00%> (-16.67%) ⬇️
tests/unit/test_daemon.py 85.18% <0.00%> (-14.82%) ⬇️
dvc/utils/fs.py 83.63% <0.00%> (-10.91%) ⬇️
tests/unit/proc/test_manager.py 89.28% <0.00%> (-10.72%) ⬇️
tests/unit/utils/test_fs.py 88.42% <0.00%> (-9.48%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop merged commit 59a4c4f into iterative:main Mar 1, 2023
efiop added a commit to efiop/dvc-s3 that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc.api.get_url: it doesn't find "md5" tag
1 participant