Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp show: don't cache collection errors #9114

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 6, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Skip caching revs that contain collection errors for now. When we have better error handling and can differentiate between errors that are cacheable (git-committed invalid files) and those that are not (retry-able network errors) we can re-enable this.

See iterative/dvc.org#4346 (comment)

@pmrowla pmrowla added ui user interface / interaction A: experiments Related to dvc exp labels Mar 6, 2023
@pmrowla pmrowla self-assigned this Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (83835af) 92.83% compared to head (bc7e7d4) 92.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9114      +/-   ##
==========================================
- Coverage   92.83%   92.82%   -0.01%     
==========================================
  Files         461      461              
  Lines       37127    37128       +1     
  Branches     5362     5363       +1     
==========================================
- Hits        34466    34464       -2     
- Misses       2130     2133       +3     
  Partials      531      531              
Impacted Files Coverage Ξ”
dvc/repo/experiments/serialize.py 84.14% <100.00%> (-1.93%) ⬇️
dvc/repo/experiments/show.py 90.57% <100.00%> (-0.08%) ⬇️
dvc/repo/experiments/queue/celery.py 85.66% <0.00%> (-1.84%) ⬇️
dvc/proc/manager.py 75.26% <0.00%> (-1.08%) ⬇️
tests/unit/test_analytics.py 100.00% <0.00%> (+2.85%) ⬆️
dvc/analytics.py 92.95% <0.00%> (+4.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit 1d2892e into iterative:main Mar 6, 2023
@pmrowla pmrowla deleted the exp-show-cache-errors branch March 6, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant