Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from appdirs to platformdirs #9131

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 7, 2023

appdirs has been deprecated/unmaintained, platformdirs is now recommended. Closes #9130.

appdirs has been deprecated/unmaintained, platformdirs is now recommended.
Closes iterative#9130.
@skshetry skshetry requested a review from efiop March 7, 2023 16:45
@skshetry skshetry added the dependencies Pull requests that update a dependency file label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (9101fce) 92.90% compared to head (88ed200) 92.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9131      +/-   ##
==========================================
- Coverage   92.90%   92.90%   -0.01%     
==========================================
  Files         456      456              
  Lines       36810    36810              
  Branches     5311     5211     -100     
==========================================
- Hits        34199    34197       -2     
- Misses       2086     2089       +3     
+ Partials      525      524       -1     
Impacted Files Coverage Δ
dvc/config.py 98.51% <100.00%> (ø)
tests/conftest.py 78.03% <0.00%> (-5.31%) ⬇️
dvc/repo/experiments/queue/celery.py 87.50% <0.00%> (+1.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit 51db176 into iterative:main Mar 7, 2023
@skshetry skshetry deleted the migrate-to-platformdirs branch March 7, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status: cannot import name 'shellcon' from win32com.shell (unknown location)
1 participant