Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio: handle revision errors when posting #9137

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

dberenbaum
Copy link
Collaborator

Context: I found this when testing out a iterative/dvclive#464 in a repo with overlapping outputs (tracking the model as both a stage output and in a .dvc file).

Before this PR:

$ dvc exp run -f
DVC failed to load some parameters for following revisions: ''.
DVC failed to load some metrics for following revisions: ''.
ERROR: Failed to reproduce experiment '9dc4c70': 'data'

After this PR:

$ dvc exp run -f
DVC failed to load some parameters for following revisions: ''.
DVC failed to load some metrics for following revisions: ''.
ERROR: output 'model' is already specified in stages:
        - train
        - model.dvc

This still isn't a good UX, but at least now I can see a somewhat more useful error.

@dberenbaum dberenbaum requested a review from daavoo March 8, 2023 19:02
@dberenbaum
Copy link
Collaborator Author

Related: #8986

@daavoo daavoo enabled auto-merge (rebase) March 8, 2023 19:12
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (0bd34c8) 92.91% compared to head (d474ec0) 92.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9137   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         456      456           
  Lines       36821    36824    +3     
  Branches     5313     5314    +1     
=======================================
+ Hits        34212    34215    +3     
  Misses       2085     2085           
  Partials      524      524           
Impacted Files Coverage Δ
dvc/repo/experiments/utils.py 82.28% <100.00%> (ø)
tests/unit/repo/experiments/test_utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo force-pushed the studio-catch-errors branch from 3b35b1b to d474ec0 Compare March 8, 2023 20:40
@daavoo daavoo merged commit fe7db32 into main Mar 8, 2023
@daavoo daavoo deleted the studio-catch-errors branch March 8, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants