Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: disable syntax highlighting on plots json output #9155

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

skshetry
Copy link
Member

I don't think it's worth it to highlight given the size of json output.

Note that highlighting was/is off when the stdout is redirected.

I don't think it's worth it to highlight given the size of json output.
@skshetry skshetry force-pushed the turn-off-higlighting branch from abadd25 to 48d8967 Compare March 10, 2023 18:52
@skshetry skshetry added enhancement Enhances DVC A: plots Related to the plots optimize Optimizes DVC labels Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.32 ⚠️

Comparison is base (aaa825a) 92.92% compared to head (48d8967) 92.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9155      +/-   ##
==========================================
- Coverage   92.92%   92.61%   -0.32%     
==========================================
  Files         456      456              
  Lines       36892    36899       +7     
  Branches     5322     5325       +3     
==========================================
- Hits        34281    34173     -108     
- Misses       2088     2181      +93     
- Partials      523      545      +22     
Impacted Files Coverage Δ
dvc/commands/plots.py 88.95% <100.00%> (ø)
dvc/ui/__init__.py 83.33% <100.00%> (+1.82%) ⬆️

... and 30 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit ef22b1d into iterative:main Mar 10, 2023
@skshetry skshetry deleted the turn-off-higlighting branch March 10, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots enhancement Enhances DVC optimize Optimizes DVC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants