Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump dvc-render>=0.3.1<0.4.0. #9197

Merged
merged 1 commit into from
Mar 16, 2023
Merged

deps: bump dvc-render>=0.3.1<0.4.0. #9197

merged 1 commit into from
Mar 16, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Mar 16, 2023 •
edited
Loading

Improve performance by removing unnecessary json.dumps calls.
See iterative/dvc-render#124

@daavoo daavoo added A: plots Related to the plots performance improvement over resource / time consuming tasks labels Mar 16, 2023
@skshetry skshetry mentioned this pull request Mar 16, 2023
Closed
@daavoo daavoo marked this pull request as ready for review March 16, 2023 18:23
@codecov
Copy link

codecov bot commented Mar 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (30c3e3e) 92.90% compared to head (7b57241) 92.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9197      +/-   ##
==========================================
- Coverage   92.90%   92.90%   -0.01%     
==========================================
  Files         457      457              
  Lines       36935    36933       -2     
  Branches     5332     5332              
==========================================
- Hits        34313    34311       -2     
  Misses       2095     2095              
  Partials      527      527
Impacted Files Coverage Δ
tests/unit/command/test_plots.py 100.00% <ø> (ø)
dvc/commands/plots.py 88.88% <100.00%> (-0.07%) ⬇️
dvc/render/convert.py 86.66% <100.00%> (-0.44%) ⬇️
tests/unit/render/test_convert.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo requested a review from a team March 16, 2023 18:56
@daavoo daavoo changed the title deps: bump dvc-render>0.2.0. deps: bump dvc-render>=0.3.0<0.4.0. Mar 16, 2023
@daavoo daavoo removed the request for review from a team March 16, 2023 19:04
@daavoo daavoo marked this pull request as draft March 16, 2023 19:04
@daavoo daavoo changed the title deps: bump dvc-render>=0.3.0<0.4.0. deps: bump dvc-render>=0.3.1<0.4.0. Mar 16, 2023
@daavoo daavoo marked this pull request as ready for review March 16, 2023 20:05
@daavoo daavoo enabled auto-merge (rebase) March 16, 2023 20:06
@daavoo daavoo merged commit 2d820cc into main Mar 16, 2023
@daavoo daavoo deleted the dvc-render-bump branch March 16, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: plots Related to the plots performance improvement over resource / time consuming tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daavoo