Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: remove feature flags for experiment sharing #9257

Merged
merged 1 commit into from
Apr 17, 2023
Merged

release: remove feature flags for experiment sharing #9257

merged 1 commit into from
Apr 17, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 28, 2023 •
edited
Loading

  • Remove feature.push_exp_to_studio flag.
  • Rename feature.studio_token and feature.studio_url to studio.token and studio.url respectively.
  • Confirm with Studio team regarding API.

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (1c39498) 92.93% compared to head (9697bd0) 92.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9257      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files         461      461              
  Lines       37319    37316       -3     
  Branches     5373     5372       -1     
==========================================
- Hits        34683    34679       -4     
  Misses       2101     2101              
- Partials      535      536       +1
Impacted Files Coverage Δ
dvc/config_schema.py 96.36% <ø> (ø)
dvc/repo/experiments/push.py 81.11% <50.00%> (+3.69%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry force-pushed the release-exp-sharing branch 3 times, most recently from f3eb58f to cc45b90 Compare April 4, 2023 07:31
@skshetry skshetry force-pushed the release-exp-sharing branch from cc45b90 to 796e3ab Compare April 4, 2023 11:59
This was referenced Apr 11, 2023
Closed
Closed
daavoo
daavoo reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skshetry I believe this is no longer blocked, can we move forward?

@omesser omesser added the A: experiments Related to dvc exp label Apr 14, 2023
@mattseddon mattseddon mentioned this pull request Apr 17, 2023
Merged
@skshetry skshetry force-pushed the release-exp-sharing branch from 796e3ab to 9697bd0 Compare April 17, 2023 03:21
@skshetry skshetry merged commit 7841020 into iterative:main Apr 17, 2023
@skshetry skshetry deleted the release-exp-sharing branch April 17, 2023 07:08
@skshetry skshetry changed the title [DO NOT MERGE] release: remove feature flags for experiment sharing release: remove feature flags for experiment sharing Apr 17, 2023
@skshetry skshetry removed the blocked label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum left review comments

@daavoo daavoo daavoo approved these changes

Assignees
No one assigned
Labels
A: experiments Related to dvc exp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skshetry @dberenbaum @daavoo @omesser