Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp show: Drop --pcp. #9270

Merged
merged 1 commit into from
May 19, 2023
Merged

exp show: Drop --pcp. #9270

merged 1 commit into from
May 19, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Mar 29, 2023 •
edited
Loading

@daavoo daavoo self-assigned this Mar 29, 2023
@daavoo daavoo linked an issue Mar 29, 2023 that may be closed by this pull request
Deprecate dvc exp show --html #9268
Closed
@daavoo daavoo added the A: experiments Related to dvc exp label Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26 ⚠️

Comparison is base (cdba65f) 91.46% compared to head (83a5091) 91.20%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9270      +/-   ##
==========================================
- Coverage   91.46%   91.20%   -0.26%     
==========================================
  Files         483      483              
  Lines       37604    37528      -76     
  Branches     5397     5390       -7     
==========================================
- Hits        34394    34228     -166     
- Misses       2642     2715      +73     
- Partials      568      585      +17
Impacted Files Coverage Δ
dvc/compare.py 97.77% <ø> (-0.05%) ⬇️
tests/func/experiments/test_show.py 99.69% <ø> (-0.04%) ⬇️
tests/unit/test_tabular_data.py 100.00% <ø> (ø)
dvc/commands/experiments/show.py 90.00% <100.00%> (+0.16%) ⬆️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo mentioned this pull request Mar 29, 2023
Merged
@dberenbaum dberenbaum added the 3.0 label May 9, 2023
@daavoo daavoo force-pushed the 9268-deprecate-dvc-exp-show-html-we-should-probably-do-this-outside-of-the-cli-if-we-want-a-parallel-coordinates-plot branch 2 times, most recently from fda8023 to 3c8f160 Compare May 16, 2023 13:41
@daavoo daavoo marked this pull request as ready for review May 16, 2023 13:41
@skshetry skshetry removed the 3.0 label May 17, 2023
@skshetry skshetry added this to the 3.0 milestone May 18, 2023
@daavoo daavoo force-pushed the 9268-deprecate-dvc-exp-show-html-we-should-probably-do-this-outside-of-the-cli-if-we-want-a-parallel-coordinates-plot branch from 3c8f160 to 83a5091 Compare May 19, 2023 09:28
@daavoo daavoo enabled auto-merge (rebase) May 19, 2023 09:28
@skshetry skshetry disabled auto-merge May 19, 2023 09:51
@skshetry skshetry merged commit 02f7fca into main May 19, 2023
@skshetry skshetry deleted the 9268-deprecate-dvc-exp-show-html-we-should-probably-do-this-outside-of-the-cli-if-we-want-a-parallel-coordinates-plot branch May 19, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry approved these changes

Assignees

@daavoo daavoo

Labels
A: experiments Related to dvc exp breaking-change
Projects
No open projects
DVC
Archived in project
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Deprecate dvc exp show --html Missing value in parallel coordinates plot
3 participants
@daavoo @skshetry @dberenbaum