Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Lazy import pytest_virtualenv #9469

Merged
merged 1 commit into from
May 17, 2023
Merged

testing: Lazy import pytest_virtualenv #9469

merged 1 commit into from
May 17, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 17, 2023

Closes #9468

@daavoo daavoo linked an issue May 17, 2023 that may be closed by this pull request
DVC causes pytest errors #9468
Closed
@daavoo daavoo marked this pull request as ready for review May 17, 2023 13:13
@daavoo daavoo self-assigned this May 17, 2023
@daavoo daavoo added the bugfix fixes bug label May 17, 2023
@daavoo daavoo requested a review from efiop May 17, 2023 13:14
@daavoo
Copy link
Contributor Author

daavoo commented May 17, 2023 •
edited
Loading

@efiop I can confirm that it solves the error

@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.25 ⚠️

Comparison is base (7f6890f) 91.60% compared to head (f23fd2f) 91.35%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9469      +/-   ##
==========================================
- Coverage   91.60%   91.35%   -0.25%     
==========================================
  Files         489      489              
  Lines       38245    38245              
  Branches     5488     5488              
==========================================
- Hits        35034    34940      -94     
- Misses       2642     2718      +76     
- Partials      569      587      +18
Impacted Files Coverage Δ
dvc/testing/benchmarks/fixtures.py 0.00% <0.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo enabled auto-merge (rebase) May 17, 2023 13:26
efiop
efiop approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@efiop efiop disabled auto-merge May 17, 2023 13:27
@efiop efiop merged commit e6e3912 into main May 17, 2023
@efiop efiop deleted the 9468-dvc-causes-pytest-errors branch May 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees

@daavoo daavoo

Labels
bugfix fixes bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DVC causes pytest errors
2 participants
@daavoo @efiop