Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove data ls and support for --meta/--desc/--label/--type cli flags #9481

Merged
merged 1 commit into from
May 19, 2023

Conversation

skshetry
Copy link
Member

Related: #7093

@@ -54,11 +23,7 @@ def run(self):
fname=self.args.file,
external=self.args.external,
glob=self.args.glob,
desc=self.args.desc,
Copy link
Member Author

@skshetry skshetry May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dberenbaum, do we also want to get rid of --desc?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop it from dvc add. We could add support for all these flags and make them write artifact info to dvc.yaml in that case, but that's probably a separate issue.

I assume .dvc files with descriptions won't break for regular data operations, right? In other words, we still allow for that field even if we don't use it at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes are for CLI. This PR affects add/import/import-url. It does not break .dvc or dvc.yaml files.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (3959c51) 91.58% compared to head (b3d3ead) 91.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9481      +/-   ##
==========================================
- Coverage   91.58%   91.55%   -0.04%     
==========================================
  Files         488      484       -4     
  Lines       38179    38011     -168     
  Branches     5476     5459      -17     
==========================================
- Hits        34968    34802     -166     
+ Misses       2642     2641       -1     
+ Partials      569      568       -1     
Impacted Files Coverage Δ
dvc/annotations.py 100.00% <ø> (ø)
dvc/commands/add.py 91.42% <ø> (-1.43%) ⬇️
dvc/commands/imp.py 81.25% <ø> (-1.11%) ⬇️
dvc/commands/imp_url.py 100.00% <ø> (ø)
dvc/repo/add.py 97.97% <ø> (-0.03%) ⬇️
dvc/repo/imp_url.py 80.00% <ø> (-0.96%) ⬇️
tests/func/test_add.py 98.72% <ø> (-0.03%) ⬇️
tests/func/test_import.py 99.44% <ø> (-0.02%) ⬇️
tests/func/test_import_url.py 100.00% <ø> (ø)
tests/unit/command/test_add.py 100.00% <ø> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry added this to the 3.0 milestone May 19, 2023
@skshetry skshetry merged commit e089ee0 into iterative:main May 19, 2023
@skshetry skshetry deleted the drop-meta-labels-desc-type branch May 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants