Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: check legacy hash name in output.add() #9646

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jun 22, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Fixes #9645

@pmrowla pmrowla self-assigned this Jun 22, 2023
@pmrowla pmrowla force-pushed the add-legacy-hash branch 2 times, most recently from 5cf0ded to e50398a Compare June 22, 2023 13:04
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (276d499) 90.33% compared to head (23135d8) 90.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9646      +/-   ##
==========================================
- Coverage   90.33%   90.33%   -0.01%     
==========================================
  Files         471      471              
  Lines       36228    36231       +3     
  Branches     5214     5214              
==========================================
+ Hits        32727    32728       +1     
- Misses       2889     2890       +1     
- Partials      612      613       +1     
Impacted Files Coverage Ξ”
tests/func/test_add.py 94.68% <ΓΈ> (ΓΈ)
dvc/output.py 84.39% <100.00%> (-0.19%) ⬇️

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit e995492 into iterative:main Jun 22, 2023
@pmrowla pmrowla deleted the add-legacy-hash branch June 22, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc add dir doesn't use new files/md5 folder in cache
2 participants