Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: status: use ui.progress instead of ui.status #9662

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 25, 2023

With all fetch and checkout related things that we've done in the recent past, we now have all the mechanisms necessary to provide actual progress (no total, but still better than spinner) during dvc data status operations.

@efiop efiop added enhancement Enhances DVC ui user interface / interaction labels Jun 25, 2023
@efiop efiop self-assigned this Jun 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
With all fetch and checkout related things that we've done in the recent past,
we now have all the mechanisms necessary to provide actual progress (no total,
but still better than spinner) during `dvc data status` operations.
@efiop efiop force-pushed the data-status-ui-progress branch from 2094076 to fb45283 Compare June 25, 2023 20:47
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (7041fa5) 90.63% compared to head (fb45283) 90.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9662      +/-   ##
==========================================
- Coverage   90.63%   90.63%   -0.01%     
==========================================
  Files         471      471              
  Lines       36259    36260       +1     
  Branches     5215     5215              
==========================================
  Hits        32864    32864              
  Misses       2811     2811              
- Partials      584      585       +1     
Impacted Files Coverage Δ
dvc/repo/data.py 97.34% <100.00%> (+0.02%) ⬆️
tests/unit/command/test_data_status.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop merged commit cf976f1 into iterative:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC ui user interface / interaction
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant