Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp pull: update for index fetch #9665

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jun 26, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

discord context: https://discord.com/channels/485586884165107732/485596304961962003/1122745985903362120

@pmrowla pmrowla added A: experiments Related to dvc exp bugfix fixes bug regression Ohh, we broke something :-( labels Jun 26, 2023
@pmrowla pmrowla self-assigned this Jun 26, 2023
@pmrowla pmrowla force-pushed the exp-pull-index-fetch branch from 54a4547 to 352491b Compare June 26, 2023 04:56
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.27 ⚠️

Comparison is base (a750a75) 90.64% compared to head (352491b) 90.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9665      +/-   ##
==========================================
- Coverage   90.64%   90.37%   -0.27%     
==========================================
  Files         472      472              
  Lines       36288    36287       -1     
  Branches     5221     5220       -1     
==========================================
- Hits        32893    32795      -98     
- Misses       2811     2885      +74     
- Partials      584      607      +23     
Impacted Files Coverage Ξ”
dvc/repo/experiments/executor/ssh.py 30.00% <0.00%> (+0.18%) ⬆️
dvc/repo/experiments/pull.py 86.66% <0.00%> (ΓΈ)

... and 26 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit 4ee4f13 into iterative:main Jun 26, 2023
@pmrowla pmrowla deleted the exp-pull-index-fetch branch June 26, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp bugfix fixes bug regression Ohh, we broke something :-(
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant