fs: make _prepare_credentails/fs_args lazy #9848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
added
skip-changelog
efiop
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #9848 +/- ##
==========================================
- Coverage 90.82% 90.35% -0.47%
==========================================
Files 473 471 -2
Lines 35996 35894 -102
Branches 5191 5177 -14
==========================================
- Hits 32692 32433 -259
- Misses 2713 2824 +111
- Partials 591 637 +46 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_prepare_credentials might check stuff and raise exceptions, which would prevent us from creating an fs instance lazilly (e.g. during index building).
Related iterative/dvc-objects#219
Related iterative/dvc-s3#47
Related iterative/dvc-azure#57
Also moving tests that broke to dvc-s3 in a separate commit, while I'm at it.