-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DataFrames and Numpy Arrays for log_plot() #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnrozhkov! Very clean and simple. I have just two overall suggestions:
- Try to require numpy and pandas as narrowly as possible
- Drop
columns
since I think users can achieve the same without it
Thanks @dberenbaum! I resolved all comments. Pls, let me know if there are other places to improve 🙌 |
Thanks @mnrozhkov! Left one last comment and then I think it's ready to merge. Do you plan to also do the docs PR? |
Yes, I plan to update the docs as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnrozhkov! Great improvement here.
This PR is a part of this issue: #750
Changes:
log_plot()
dvclive/utils.py/convert_datapoints_to_list_of_dicts
pandas
andnumpy
log_plot()
:columns: Optional[List[str]] = None,
- optional list of column names for data in Numpy Array formatJN to test new feature: log_plots.ipynb
TODO
guide.