-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate all CML repositories from a single repository #101
Conversation
This is mostly done. It may have duplicate files that are better to be removed but I didn't check them before your approval.
I didn't add gitlab and bitbucket yet, need to make sure that this is the right approach first.
There was a I didn't use any dvc specific code, only the push script runs I didn't add support for tags, but if you need them I can add another level of directories for tags. This doesn't use any modifications to the committer name and commit date, yet. These can be modified per-hub basis. Let me know what you think and would like to see here. Thanks. @casperdcl @iterative/cml @shcheklein |
I know you're busy with the release but maybe you have time for a quick review to this one: @casperdcl |
ping! @casperdcl :) |
ping :) |
🙏🏼 Thank you very much, @iesahin! This is an awesome stride in the right direction, and we should review it rather sooner than later. @casperdcl, like the rest of the team, is a bit busy with releases, but we should track this issue somewhere so it doesn't get lost in the meanwhile. |
Please ping |
When do you think you could have more time to review this? @iterative/cml |
I guess that the answer is going to be “after the release” 🙃 |
@iesahin I think it's almost impossible to review. Let's split into some baby steps please. One project at a time. 100-500 line PRs if possible ...? |
|
I think the approach leads to a lot of code (14k lines) which could be avoided...
|
As per iterative/cml#1000 (comment), iterative/cml_dvc_case should be updated to replace |
I think with my time constraints until July, I'll close this as is to (maybe) reopen sometime later. Thank you for your reviews. |
This one is to add a
generate.bash
script that creates multiple CML example repositories from a single seed repository.Closes #100