Finish restructuring example-get-started + gen updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jorgeorpinel
changed the title
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
changed the title
This comment has been minimized.
This comment has been minimized.
shcheklein
reviewed
Aug 21, 2019
|
Note I just rewrote https://github.com/iterative/example-get-started to match the changes in this PR. |
shcheklein
reviewed
Aug 21, 2019
| REPO_NAME="example-get-started" | ||
| REPO_PATH="../$REPO_NAME" | ||
| REPO_PATH="$HERE/build/$REPO_NAME" |
There was a problem hiding this comment.
Good thinking. build/ is already in the root .gitignore but that was a coincidence. Will add the the directory .gitignore too.
There was a problem hiding this comment.
Added in 1a9ce81 (will show up in my next PR).
shcheklein
approved these changes
Aug 21, 2019
|
@jorgeorpinel I've merged, there were one-two unresolved comments - please take a look if something of them are not resolved yet. |
jorgeorpinel
added a commit
that referenced
this pull request
Aug 21, 2019
casperdcl
pushed a commit
that referenced
this pull request
Aug 27, 2021
jorgeorpinel
changed the title
jorgeorpinel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches iterative/dvc.org#561 (for fixing iterative/dvc.org#560)