Add sorting function to sort dash command above normal one #106
Conversation
| const sortDashedCommand = (a, b) => { | ||
| if (a.split('-')[0] === b) return -1 | ||
| return 0 | ||
| } |
There was a problem hiding this comment.
I thought this sort function looked funny, so I stuck it in the Node REPL and tried it out. It works when the dashed commands are next to each other:
> ['abc', 'ab', 'ab-c', 'abcd'].sort(sortDashedCommand)
[ 'abc', 'ab-c', 'ab', 'abcd' ]
but not when there is anything in between:
> ['ab', 'abc', 'ab-cd', 'ab-c'].sort(sortDashedCommand)
[ 'ab', 'abc', 'ab-cd', 'ab-c' ]
I get what this is going for, and I think given the order we usually give it this will work, but we may want a more guaranteed sort here that explicitly puts commands with - above all others, or if we want to keep the aesthetics of grouped commands we could use a reducer that collects dashed and non-dashed commands, putting together a list ensuring they're grouped by first segment but the non-dashed base is last in each group.
That said, it's better than nothing, so I wouldn't consider it a blocker.
There was a problem hiding this comment.
This is supposed to fix the particular case that the dashed command are next to each other for now. So, if we encounter another case scenario you mentioned later, we can come up with a fix.
Everything looks good on generated commands list #100 except for order on dashed commands. So, I have added a sorter to move dashed commands higher for proper syntax highlighting.