-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command line linker, syntax highligher for GTO #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks like quickfix material, and I don't love the GTO nested page being added as a default for all sites, but we need to unblock GTO docs anyway so we can revisit this in a larger highlighter overhaul in the future.
argsLinkerPath: [ | ||
'command-reference', | ||
`ref`, | ||
'cli-reference', | ||
'gto/command-reference' | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be specified in a consumer project's config. It'd also probably be best if we add glob and/or regex functionality, something like '/command-reference/`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I updated it to check on the whole path, not at the start of the path.
Hi! Thank you guys! 👍🏻 When it's going to appear in https://mlem-ai-gto-docs-pzdfnkadkdwtv.herokuapp.com/doc/gto/command-reference? This is the PR iterative/mlem.ai#199 I just merged |
You're right that we'll need to ship and merge into mlem.ai before we'll see it on that PR. We've got a big incompatible update in |
Hey @aguschin! Just did the maintenance port over at #131, and added a PR off of yours at iterative/mlem.ai#227 which should solve your issue. Let me know if there's any trouble adding it in! |
It will add support for GTO command line linker, and prismjs syntax highlighting.
I have copied the GTO docs as of now so that we can see them in action.
https://gatsby-theme-nested-com-bxpqrq.herokuapp.com/doc/gto
The setup we have used for syntax highlighting, command line linker, ...etc. is kind of hard-coded onto the theme but it would be better if it is based on the individual consumer projects. We need to generalize this so that the required data will be supplied from the consumer project and the theme will handle only the logical portion of it. I will create a ticket for this.
Fixes #122