Updates for dvc.org integration #130
Conversation
rogermparent
temporarily deployed
to
gatsby-theme-dvc-integr-ejirjg
rogermparent
force-pushed
the
dvc-integration-updates
branch
from
633d854 to
864bcb3
Compare
rogermparent
temporarily deployed
to
gatsby-theme-dvc-integr-a0fkxh
rogermparent
temporarily deployed
to
gatsby-theme-dvc-integr-a0fkxh
…to dvc-integration-updates
rogermparent
temporarily deployed
to
gatsby-theme-dvc-integr-a0fkxh
| <div | ||
| className={cn( | ||
| styles.alert, | ||
| 'w-full', | ||
| 'transition-all', | ||
| 'ease-in-out', | ||
| 'delay-150', | ||
| collapsed ? ['h-0'] : ['h-7'] | ||
| 'whitespace-nowrap', | ||
| 'text-center', | ||
| 'truncate', | ||
| 'overflow-hidden', | ||
| 'px-2', | ||
| collapsed ? 'h-0' : 'h-7' | ||
| )} | ||
| > | ||
| <span role="img" aria-label="rocket"> | ||
| 🚀 | ||
| </span>{' '} | ||
| <Link href="https://studio.iterative.ai">DVC Studio</Link>, the online UI | ||
| for DVC, is live!{' '} | ||
| <span className="align-middle"> | ||
| <AlertContent /> | ||
| </span> | ||
| </div> |
There was a problem hiding this comment.
Tweaked Alert component and extracted the content specifically to its own component. We can update it here to populate to all sites on update, or shadow to override per-site.
| import React from 'react' | ||
|
|
||
| import Link from '../../Link' | ||
| import { ReactComponent as LogoSVG } from '../../../images/dvc_icon-color--square_vector.svg' | ||
| import * as styles from './styles.module.css' | ||
|
|
||
| export const HeaderBranding = () => ( | ||
| <> | ||
| <Link href="/" className={styles.logoLink} title="DVC" aria-label="DVC"> | ||
| <LogoSVG className={styles.logo} /> | ||
| </Link> | ||
| <Link | ||
| className={styles.company} | ||
| href="https://iterative.ai/" | ||
| target="_blank" | ||
| > | ||
| by <span className={styles.companyName}>iterative.ai</span> | ||
| </Link> | ||
| </> | ||
| ) |
There was a problem hiding this comment.
Refactored branding into its own component so we can override it per-site more easily without shadowing the whole header.
|
|
||
| import navLinkItemsData from './data' | ||
| import navLinkItemsData from '../../../../data/headerNav' |
There was a problem hiding this comment.
This data file is very different between this example site and dvc.org. Slightly excessive shadowing paves over it, but we'll need something better soon (we have a ticket for something like this).
| } | ||
|
|
||
| export interface INavLinkPopupData extends INavLinkCommonData { | ||
| popup: PopupName | ||
| text: string | ReactNode |
There was a problem hiding this comment.
Type fix, some pieces of data have a React component as its text.
| @@ -4,6 +4,7 @@ import cn from 'classnames' | |||
|
|
|||
| import 'reset-css' | |||
| import './base.css' | |||
| import './fonts.css' | |||
There was a problem hiding this comment.
Allows us to shadow specifically this fonts file without needing to clobber the rest of base.css.
| import { getFirstPage } from '../../../../utils/shared/sidebar' | ||
| import { INavLinkData, INavLinkPopupData } from './types' | ||
| import { getFirstPage } from '../utils/shared/sidebar' | ||
| import { | ||
| INavLinkData, | ||
| INavLinkPopupData | ||
| } from '../components/LayoutHeader/Nav/LinkItems/types' | ||
|
|
||
| const docsPage = getFirstPage() | ||
|
|
There was a problem hiding this comment.
Thought this would be a better place for this data file, but could and probably will be improved.
Good idea! We absolutely need a better nav system, but I decided to deliberately hold myself back from bloating this PR with a big nav overhaul that would make it take longer. We can discuss more during the planning meeting. |
These are changes that made integration with dvc.org and the new version better/easier/possible.
Companion to iterative/dvc.org#4118, which depends on this being merged and shipped.