More dvc.org implementation fixes #140
Conversation
| h1:first-child { | ||
| @apply lg:h-14 pb-2; | ||
| @apply pb-2 min-h-[3.5rem]; |
There was a problem hiding this comment.
min-h over h fixes an issue where line broken titles were off
| * { | ||
| @apply scroll-mt-14; | ||
| } | ||
|
|
There was a problem hiding this comment.
scroll margin now is on the header, since it's pretty much coupled. We use Tailwind's 14 (3.5rem) but this makes me think we may want to specify a tailwind custom value.
| @@ -44,6 +44,7 @@ | |||
| h4, | |||
| h5, | |||
| h6 { | |||
| @apply scroll-mt-5; | |||
There was a problem hiding this comment.
scroll-pt-top on the body makes up for the sticky header exactly, and elements that want to have a little extra space can set scroll-mt to be used in addition.
There was a problem hiding this comment.
Nice addition. I think we can add them to other linkers as well like details link, args link etc which also provide hash links beside headers.
| @@ -44,6 +44,7 @@ | |||
| h4, | |||
| h5, | |||
| h6 { | |||
| @apply scroll-mt-5; | |||
There was a problem hiding this comment.
Nice addition. I think we can add them to other linkers as well like details link, args link etc which also provide hash links beside headers.
For use with iterative/dvc.org#4118, which will depend on this being merged and shipped to fix some issues.