Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping title template #96

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

yathomasi
Copy link
Contributor

This is a current requirement for the iterative.ai website from the marketing team. They don't want to have a | Iterative at the end of About page and Why Iterative page. We could have simply skipped the title template for the whole website and have them manually added individually wherever necessary.

But, using the existing functionality and allowing to skip looked like a better approach to me.

Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent patch, we'll probably do something more graceful when we try out Gatsby's Head API so I'm even more happy not being a stickler for implementation.

@yathomasi yathomasi temporarily deployed to gatsby-theme-allow-skip-vudhdw October 25, 2022 14:08 Inactive
@yathomasi yathomasi enabled auto-merge October 25, 2022 14:08
@yathomasi yathomasi merged commit 8964300 into main Oct 25, 2022
@yathomasi yathomasi deleted the allow-skipping-template-title branch October 25, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants