Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GTO v1+ #39

Closed
shcheklein opened this issue Aug 14, 2023 · 0 comments · Fixed by iterative/gto#382
Closed

Update to GTO v1+ #39

shcheklein opened this issue Aug 14, 2023 · 0 comments · Fixed by iterative/gto#382
Labels
bug Something isn't working p1-important Current backlog of issue that we are addressing atm

Comments

@shcheklein
Copy link
Member

There were some issues related to the semantics change:

gto check-ref refs/tags/myfmmodel#dev#2

vs

gto check-ref myfmmodel#dev#2

In GTO v1 the first version is not working anymore and actions depends on it (GH returns a ref in that form). Needs to be fixed on the GTO side or here.
@shcheklein shcheklein added p1-important Current backlog of issue that we are addressing atm bug Something isn't working labels Aug 14, 2023
@shcheklein shcheklein assigned shcheklein and unassigned shcheklein Aug 14, 2023
@pmrowla pmrowla mentioned this issue Aug 21, 2023
Merged
pmrowla added a commit to iterative/gto that referenced this issue Aug 21, 2023
@pmrowla
registry: fix check_ref with full ref name (#382)
6296c29 
Will fix iterative/gto-action#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p1-important Current backlog of issue that we are addressing atm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

registry: fix check_ref with full ref name pmrowla/gto
2 participants
@shcheklein @aguschin