-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable remote git repos for check-ref
, history
, and stages
#273
Conversation
…2. a path to a local repo 3. a url to remote repo
Enable show to work on a remote repo
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
…l commands support it
mmm... why so many commits? I did sync my main with the iterative main before pushing new commits... what should I have done differently? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
@@ -209,7 +209,7 @@ def GTOGroupSection(section): | |||
".", | |||
"-r", | |||
"--repo", | |||
help="Repository to use (remote repos accepted)", | |||
help="Repository to use", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Saw it but for some reason forgot to add a comment on this.
def convert_objects_to_str_in_json_serializable_object( | ||
o: Union[list, dict] | ||
) -> Union[list, dict]: | ||
return json.loads(json.dumps(o, default=str)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Didn't know there is a default
arg. Maybe this stuff I wrote earlier wasn't needed with this :) https://github.com/iterative/gto/blob/main/gto/utils.py#L24
I assume this is because you didn't fetched upstream in the repo, so after the previous PR was merged, your UPD: waiting to resolve your comment about datetimes and timezones. |
Codecov ReportBase: 81.88% // Head: 82.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 81.88% 82.79% +0.90%
==========================================
Files 16 17 +1
Lines 1905 1953 +48
==========================================
+ Hits 1560 1617 +57
+ Misses 345 336 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Got it thanks! Not used to the github fork-pull strategy (I come from GitLab MRs...) |
No description provided.