Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote git repos for check-ref, history, and stages #273

Merged
merged 36 commits into from
Sep 21, 2022

Conversation

francesco086
Copy link
Contributor

No description provided.

Francesco Calcavecchia and others added 30 commits September 13, 2022 19:48
…2. a path to a local repo 3. a url to remote repo
Enable show to work on a remote repo
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
@francesco086
Copy link
Contributor Author

mmm... why so many commits? I did sync my main with the iterative main before pushing new commits... what should I have done differently?

Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@@ -209,7 +209,7 @@ def GTOGroupSection(section):
".",
"-r",
"--repo",
help="Repository to use (remote repos accepted)",
help="Repository to use",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Saw it but for some reason forgot to add a comment on this.

def convert_objects_to_str_in_json_serializable_object(
o: Union[list, dict]
) -> Union[list, dict]:
return json.loads(json.dumps(o, default=str))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't know there is a default arg. Maybe this stuff I wrote earlier wasn't needed with this :) https://github.com/iterative/gto/blob/main/gto/utils.py#L24

@aguschin
Copy link
Contributor

aguschin commented Sep 21, 2022

mmm... why so many commits? I did sync my main with the iterative main before pushing new commits... what should I have done differently?

I assume this is because you didn't fetched upstream in the repo, so after the previous PR was merged, your main branch contained all those commits, being branched out from the HEAD of main few commits back. NP :) Merging this!

UPD: waiting to resolve your comment about datetimes and timezones.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 81.88% // Head: 82.79% // Increases project coverage by +0.90% 🎉

Coverage data is based on head (33fdc1a) compared to base (a3cefdb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   81.88%   82.79%   +0.90%     
==========================================
  Files          16       17       +1     
  Lines        1905     1953      +48     
==========================================
+ Hits         1560     1617      +57     
+ Misses        345      336       -9     
Impacted Files Coverage Δ
gto/api.py 91.33% <100.00%> (+0.35%) ⬆️
gto/cli.py 70.43% <100.00%> (ø)
gto/constants.py 100.00% <100.00%> (ø)
gto/git_utils.py 100.00% <100.00%> (ø)
gto/base.py 87.25% <0.00%> (+1.41%) ⬆️
gto/tag.py 86.39% <0.00%> (+2.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@francesco086
Copy link
Contributor Author

Got it thanks! Not used to the github fork-pull strategy (I come from GitLab MRs...)

@aguschin aguschin merged commit 24c165a into iterative:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants