Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run on py311 #408

Merged
merged 2 commits into from
Sep 14, 2023
Merged

run on py311 #408

merged 2 commits into from
Sep 14, 2023

Conversation

skshetry
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
gto/cli.py 0.00%

📢 Thoughts on this report? Let us know!.

@pmrowla
Copy link
Contributor

pmrowla commented Sep 14, 2023

gto CI linter steps fail in 3.11 (see #400)

@skshetry
Copy link
Member Author

@pmrowla , I have updated from py-template.

@@ -657,7 +657,9 @@ def check_ref(
), "Only one output formatting flags is allowed"
result = gto.api.check_ref(repo, ref)
if len(result) > 1:
NotImplementedInGTO("Checking refs that created 1+ events is not supported")
raise NotImplementedInGTO(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a bug, where an exception was not being raised.

@skshetry skshetry merged commit 27a28ea into main Sep 14, 2023
@skshetry skshetry deleted the py3.11 branch September 14, 2023 07:39
@skshetry skshetry temporarily deployed to pypi September 14, 2023 07:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants