fix(tags): parse timezone information from a tag #425

shcheklein · 2023-10-09T19:50:30Z

We don't parse timezones, means we are not getting right dates in Studio. Also Studio tests produce a lot of warning about "naive" date times.

Not critical, but better to fix in advance.

gto/tag.py

codecov-commenter · 2023-10-25T02:21:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
gto/index.py	`80.73% <ø> (-0.07%)`	⬇️
gto/tag.py	`92.50% <100.00%> (ø)`

📢 Thoughts on this report? Let us know!.

pmrowla · 2023-10-25T03:08:39Z

We should also bump the scmrepo minver to 1.4.0 in setup.py, other than that LGTM

shcheklein commented Oct 9, 2023

View reviewed changes

gto/tag.py Outdated Show resolved Hide resolved

shcheklein self-assigned this Oct 9, 2023

shcheklein requested a review from pmrowla October 9, 2023 19:52

shcheklein added the bug Something isn't working label Oct 9, 2023

shcheklein removed the request for review from pmrowla October 9, 2023 21:22

shcheklein marked this pull request as draft October 9, 2023 21:22

pmrowla reviewed Oct 17, 2023

View reviewed changes

gto/tag.py Outdated Show resolved Hide resolved

shcheklein force-pushed the gto-tags-tz branch 3 times, most recently from b663285 to 4b444dd Compare October 25, 2023 02:19

shcheklein requested a review from pmrowla October 25, 2023 02:22

shcheklein marked this pull request as ready for review October 25, 2023 02:23

shcheklein temporarily deployed to pypi October 25, 2023 02:39 — with GitHub Actions Inactive

fix(tags): parse timezone information from a tag

18791b4

shcheklein force-pushed the gto-tags-tz branch from 4b444dd to 18791b4 Compare October 25, 2023 21:22

shcheklein temporarily deployed to pypi October 25, 2023 21:26 — with GitHub Actions Inactive

shcheklein merged commit 44a9878 into main Oct 25, 2023
17 checks passed

shcheklein deleted the gto-tags-tz branch October 25, 2023 21:36