Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: don't wait on check/tests to release #436

Merged
merged 1 commit into from
Dec 15, 2023
Merged

gha: don't wait on check/tests to release #436

merged 1 commit into from
Dec 15, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 15, 2023

Stuff might be flaky or super slow. All the testing that we need is done during development/PRs, no good reason to throttle it.

@efiop
gha: don't wait on check/tests to release
038776c 
Stuff might be flaky or super slow. All the testing that we need is done during development/PRs, no good reason to throttle it.
@efiop efiop merged commit 75a98d5 into main Dec 15, 2023
@efiop efiop deleted the efiop-patch-1 branch December 15, 2023 02:10
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop